search

valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Add SSH command for executions #314

Closed memona008 closed 2 months ago

memona008 commented 3 months ago

Resolves #312 User will be able to remotely debug the execution

  1. He can either provide address:port & private key by himself or run the command for auto collection of the details
  2. If the key is generated in CLI while starting the execution it can be found by command and prompted to user as option
  3. But if the execution is started by UI or key is generated somewhere user HAS to provide that key as command argument --private-key-file

ssh.webm

tarekoraby commented 3 months ago

Does this resolve #312?

I assume this is the final piece of #7172. If so, please share a screenshot or a recording of the typical steps the end user will experience after merging this PR.

memona008 commented 3 months ago

If so, please share a screenshot or a recording of the typical steps the end user will experience after merging this PR.

Thanks for the reminder. I'll do it once all the comments are addressed and PR is in its final shape so that our CS would get the latest and final recording/screenshot/steps.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 31.85185% with 92 lines in your changes missing coverage. Please review.

Project coverage is 85.12%. Comparing base (59dc814) to head (905c1b8). Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
valohai_cli/utils/ssh.py 30.68% 59 Missing and 2 partials :warning:
valohai_cli/commands/execution/ssh.py 37.50% 15 Missing :warning:
valohai_cli/utils/__init__.py 30.76% 9 Missing :warning:
..._cli/commands/execution/run/dynamic_run_command.py 28.57% 4 Missing and 1 partial :warning:
...hai_cli/commands/execution/run/frontend_command.py 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #314 +/- ## ========================================== - Coverage 86.85% 85.12% -1.73% ========================================== Files 126 128 +2 Lines 4374 4539 +165 Branches 903 944 +41 ========================================== + Hits 3799 3864 +65 - Misses 394 489 +95 - Partials 181 186 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.