search

valohai / valohai-utils

Python helper library for Valohai
MIT License
2 stars 2 forks source link

Make parsing parameter from CLI work properly when it is a list #128

Closed dangquangdon closed 6 months ago

dangquangdon commented 7 months ago

Let argparser knows how to properly parse the parameter of type list by providing a callback that split the parameter using comma as default.

dangquangdon commented 7 months ago

@akx I changed the approach and also described it in the PR description

akx commented 7 months ago

I emdraftened this – I think we need to design this new stepconfig.json thing a little more first since it'd be forever a part of the /valohai/ mount structure (and would need to eventually be documented like the others at https://docs.valohai.com/hc/en-us/articles/18704309491473-System-Configuration-Files and so on).

dangquangdon commented 7 months ago

I emdraftened this – I think we need to design this new stepconfig.json thing a little more first since it'd be forever a part of the /valohai/ mount structure (and would need to eventually be documented like the others at https://docs.valohai.com/hc/en-us/articles/18704309491473-System-Configuration-Files and so on).

Good to know that we have to document it publicly 👍 . My idea is stepconfig.json is simply just the information of the step defined in valohai.yaml 🤔

dangquangdon commented 7 months ago

@akx I reduce the scope of this PR now to only parse the parameter's value using comma as default. We will make further changes once we find out a good way to get multiple-separator from peon and roi