Beyond the particular comments, I'm a little concerned about the global state strewn around the various modules by these PRs.
Would it maybe be better to wrap them all in a singleton object (that could, since it's rather related, it seems, also wrap that execution ID thing)? That way they could be easily inspected and cleared if need be...
(Furthermore, an object like that could have a class hierarchy with one class for local runs, the other for Valohai cloud runs...)
I agree we should wrap global state into single place.
However, I think it is easier if we do it separately after all these PRs are in.
I agree we should wrap global state into single place.
However, I think it is easier if we do it separately after all these PRs are in.