search

valohai / valohai-utils

Python helper library for Valohai
MIT License
2 stars 2 forks source link

valohai.prepare() to create initial inputs.json and parameters.json for local runs #8

Closed JuhaKiili closed 4 years ago

akx commented 4 years ago

Do we actually need to even write inputs.json/parameters.json onto disk?

If we assume people will use the valohai package APIs here to access these files, why not just synthesize them when someone calls e.g. get_parameters() or whatever?

I'll review the changes nevertheless though :)

JuhaKiili commented 4 years ago

Do we actually need to even write inputs.json/parameters.json onto disk?

If we assume people will use the valohai package APIs here to access these files, why not just synthesize them when someone calls e.g. get_parameters() or whatever?

I'll review the changes nevertheless though :)

The downloader code needs inputs.json to match input names to URIs.

Not sure we need parameters.json, but I felt like having it for consistency.