search

valor-labs / valor-launchpad

2 stars 2 forks source link

Message info too fast to display #611

Open sawyerbutton opened 2 years ago

sawyerbutton commented 2 years ago

Title

Check Pages functionality works

Description

User data entered on the settings page must be checked before saving

Expected

Any successful message appears after entering a strong password in the 'New password' and reentering the same data in the 'Verify password' field on the Pages/Pages/Settings/Profile Settings/Password page.

Issue

Successful message “Good job. This is a great password ”appears in front of the“ New Password ”field immediately after you enter any character in this field, even if the“ Confirm Password ”field is empty. The error message 'Password is incorrect' appears after entering the same strong password into 'New password' and "Verify password' fiels and taping on 'Save changes' button

Dev's comment

sawyerbutton commented 2 years ago

@apotapcukv this good job, great password is a help message for user to inform they input a secured password , It is about password validation config, like password should include @!1-9a-z as necessary characters. But we need to show this message as a smooth way. @YeomanWang

sawyerbutton commented 2 years ago

image image

@YeomanWang

If there are no strong password check-boxes being selected, Then there should be nonice password promt. And there should a server error here while save the password.

apotapcukv commented 2 years ago

Preconditions: Log out and then log in to the site with an existing account Steps to reproduce this issue:

  1. Go to the Pages/Settings page
  2. Click on the ‘Pasword’ button pleased on ‘Profile Settings’ page
  3. Fill in the ‘Current password’ field with current password data and add to the ‘New password’ and ‘Verify password’’ field number 1 on the Password page
  4. Click on the ‘Save changes’ button placed on the Password page Actual result: ‘Nice work, This is an excellent password’’ successful checkbox appears before the ‘New password field on the Password page before clicking on the ‘Save changes’ button on the Settings/Password page. And a successful ‘Update password?’ popup opens on the Settings page with filled Username and Password field (with the poor password) Expected result: A server error occurs when storing a poor password for a user account https://docs.google.com/presentation/d/1CfFmKOSxmXuewX1XkNFKCtFEbGou290TAMPeZUw-BE8/edit?usp=sharing
YeomanWang commented 2 years ago

@apotapcukv cc @sawyerbutton The password strong validation is in frontend, that is real time valid if the password input lose focus , not from the server side, if the password is not valid, then the "Save Changes" button can not be clicked.