search

valor-labs / valor-launchpad

2 stars 2 forks source link

Project picture changed issue #614

Open sawyerbutton opened 2 years ago

sawyerbutton commented 2 years ago

Title

Check Pages functionality works

Description

Projects can be cloned using 'Clone' link on the Project dropdown sidemenu

Expected

Only projects owners should be allowed to change Projects settings, including Project picture

Issue

The project picture was accidentally changed on the site.

Dev's comment

sawyerbutton commented 2 years ago

image It may be a seed update issue.

sawyerbutton commented 2 years ago

@ErikYu I am trying to find the seed data generation logic in the system but got nothing. Please help me to define this issue.

ErikYu commented 2 years ago

@sawyerbutton As we are using faker.js to generate mock pictures, is returns one url. And the url's pic will change dynamiclly. eg: http://placeimg.com/640/480

sawyerbutton commented 2 years ago

@sawyerbutton As we are using faker.js to generate mock pictures, is returns one url. And the url's pic will change dynamiclly. eg: http://placeimg.com/640/480

But there is no way to user edit project picture, We should have a way to edit picture file, This is another issue with lower priority.

@apotapcukv, as fake data, these picture' resource file coming from random web-pic, I feel it is okay for now, and I will create a new enhancement issue for this as lower priority.