search

valor-labs / valor-launchpad

2 stars 2 forks source link

fixes #595. #667

Closed xiehongyang closed 2 years ago

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 86bbd35):

https://valor-launchpad-3824c--pr667-ui-595-97levkaq.web.app

(expires Sun, 12 Dec 2021 07:18:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

sawyerbutton commented 2 years ago

@xiehongyang Issue 595 is not about sidebar, it'a about duplicate feature sticky & fixed. Please review original site to fix this.

sawyerbutton commented 2 years ago

@xiehongyang While config set to sticky the side menu's scroll will not influence the whole page. While config set to fixed, the side menu is binding with the whole page, scroll will trigger whole page's scroll event.