search

valor-labs / valor-launchpad

2 stars 2 forks source link

fix(sign-up-issue): #634 fix Sign up page, need a password confirmation field #681

Closed YeomanWang closed 2 years ago

YeomanWang commented 2 years ago

fix(sign-up-issue): #634 fix Sign up page, need a password confirmation field

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit dd9e9cf):

https://valor-admin-sales--pr681-sign-up-issue-5sjt0r8m.web.app

(expires Tue, 21 Dec 2021 04:16:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

sawyerbutton commented 2 years ago

https://stackblitz.com/edit/angular-u47bxp?devtoolsheight=33&file=src/app/app.component.html

@YeomanWang I am trying to reproduce the validation in the code but got a not proper result, please check it and ping me.

  1. confirm password validation does not reflect the password's change.
  2. error message display while there is no diff between pass & confirm pass

Code has no issue, my mistake sorry.