search

valor-software / ng2-dragula

Simple drag and drop with dragula
http://valor-software.com/ng2-dragula/
MIT License
1.91k stars 430 forks source link

[feature request] Could you support the slideFactorY and slideFactorX options ? #1086

Open ValerioEmanuele opened 1 year ago

ValerioEmanuele commented 1 year ago

REQUIRED: Before filing a feature request

Is your feature request related to a problem? Please describe. Hello, I need to ignore the drag & drop when the users do a little movement because this is causing some issues.

Describe the solution you'd like I saw that inside, you're using the following dependency: "@types/dragula": "^2.1.34",

And the slideFactorY and slideFactorX properties are not present in this version on the interface DragulaOptions although Dragula has supported them for several years.

A clear and concise description of what you want to happen.

Describe alternatives you've considered

I limited the drag & drop area using the options you provided, e.g., moves(), revertOnSpill, removeOnSpill, etc. But they are never called because the movement is so little that they are not considered.

ValerioEmanuele commented 1 year ago

@valorkin , @cormacrelf, any chance to have it implemented?

ValerioEmanuele commented 7 months ago

Hello @cormacrelf , @valorkin

I hope this message finds you well. I am reaching out to bring your attention to this issue.

In support of this feature request, I have contributed a PR to the DefinitelyTyped repository that has been successfully merged. You can view the PR here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69382. This PR introduces the slideFactorX and slideFactorY properties, which I believe could significantly enhance the drag-and-drop functionality in ng2-dragula by allowing fine control over the drag sensitivity.

I kindly request that you consider reviewing and integrating these enhancements into the ng2-dragula project. Implementing these properties could simplify the adoption of customized drag thresholds for many developers using your library.

Thank you for considering this integration. I look forward to your feedback and hope for a positive response.

Best regards