valor-software / ng2-dragula

Simple drag and drop with dragula
http://valor-software.com/ng2-dragula/
MIT License
1.91k stars 430 forks source link

Update package.json #1100

Closed joeskeen closed 8 months ago

joeskeen commented 10 months ago

Allow peer dependency of Angular 17

Relevant issues

Fixes #1099

anas3636 commented 9 months ago

Hello ! Thank you so much for the amazing work on this library ! Just wondering when will you be able to make this pull request so we can migrate to angular 17

Thank u <3

ugiordan commented 7 months ago

This is still failing:

npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name ">=^16.0.0 <=^17.0.0" of package "@angular/animations@>=^16.0.0 <=^17.0.0": Tags may not have any characters that encodeURIComponent encodes.

I had to workaround using:

"overrides": {
    "ng2-dragula": {
      "@angular/common": "$@angular/common",
      "@angular/core": "$@angular/core",
      "@angular/animations": "$@angular/animations"
    }
  }