[usage question] Purpuse of shipping two package.json files

vladimiry commented 5 years ago

REQUIRED: Before filing a usage question

Change each [ ] to [x] when you have done it.

[x] My issue title starts with [usage question]
[x] I have read the README, especially the 'classic blunders' section
[x] I have looked at the demos to see if my use case has obvious examples.
[x] I have searched the ng2-dragula issues, including closed issues.
[x] I have browsed the issues labeled "future reference" for problems that have been solved before.

Use case description (required)

The npm published package doesn't seem to be compatible with to be released soon Ivy Renderer (Renderer3). See this issue https://github.com/angular/angular/issues/29703 for details.

Is there any special purpose in shipping two package.json files?

cormacrelf commented 5 years ago

Will accept a PR that changes it to use ng-packagr.

mattlewis92 commented 5 years ago

@cormacrelf I just hit the original issue described here and was going to contribute a fix, but it looks like there's nothing to change. Just when publishing you need to do npm publish modules/ng2-dragula/dist instead of npm publish modules/ng2-dragula and everything should just work. Any chance you could publish a new version with that change? Thanks! 😄

Edit: I didn't spot you were using lerna to publish, I just sent a small patch your way that should make the required changes for this to work: https://github.com/valor-software/ng2-dragula/pull/962

ssougnez commented 5 years ago

Hi,

do you know when you plan on releasing the fix? This tiny issue prevent me to test if ivy works for me :-)

Thanks

valor-software / ng2-dragula

[usage question] Purpuse of shipping two package.json files #951