search

valor-software / ng2-file-upload

Easy to use Angular components for files upload
http://valor-software.github.io/ng2-file-upload/
MIT License
1.91k stars 662 forks source link

detecting when files have uploaded and other events #891

Open figuerres opened 7 years ago

figuerres commented 7 years ago

it seems like this could use some events to notify the calling code of the status changes.

kind of like @Output() onVoted = new EventEmitter(); https://angular.io/guide/component-interaction

i am not sure how to best contribute the code for this, i think i can take the code an make a localversion but then no one else gets the benefit.

so that in a component it can get an event in a function to handle things like file x was uploaded take it out of the queue display and update my grid of files on the server.

is anyone working on this kind of update ? does anyone have a fork where they did it ?

adrianfaciu commented 6 years ago

If you have a local version of this a PR would be awesome 😄

AckerApple commented 6 years ago

I have finished addressing this in v0.2.0 of angular-file

Recommend moving to my fork for the requested functionality

adrianfaciu commented 6 years ago

@AckerApple there are still a lot of people using this in their applications, already in production. At least some of them would like to keep using it, as it might not be that easy for them to upgrade to something else.

AckerApple commented 6 years ago

@figuerres reported this same issue on my fork: https://github.com/AckerApple/angular-file/issues/2

Of course people have this package in production and may want to keep using it. Doesn't mean I shouldn't be helpful and mention the functionality they seek is available elsewhere.

If it bothers you that I'm all up in your package, it wouldn't be the first time I've heard that. I have not been blocked by a package, nor am I trolling... Doing what I think is helpful.

adrianfaciu commented 6 years ago

Did not suggest you are trolling or bothering someone, just pointed out a scenario for some people, including myself. I'm not directly related to valour-software, but since I'm using this package I'm trying to give a hand to keep it more updated 😄

AckerApple commented 6 years ago

Yo extra thanks for maintaining this package. Big fan.

Understood.