valor-software / ng2-select

Angular based replacement for select boxes
http://valor-software.github.io/ng2-select/
MIT License
675 stars 585 forks source link

bootstrap@4.0.0-alpha.6 breaks dropdown css #596

Open jspenc72 opened 7 years ago

jspenc72 commented 7 years ago

Just a warning that the 4.0.0 alpha release for bootstrap 4 breaks the drop down css.

You can reproduce error with

npm i bootstrap@next --save 

or

npm i bootstrap@4.0.0-alpha.6 --save
anrepppp commented 7 years ago

+1

anrepppp commented 7 years ago

what is the solution?

jspenc72 commented 7 years ago

I locked my dependency at a compatible version for now... I haven't seen any solutions. @anvesh48

andreirk commented 7 years ago

+1

jmls commented 7 years ago

anyone got a fix for this ? desperately need the select to work ;)

caglarturkurka commented 7 years ago

Hi, I wonder that when will you solve ng2-select problem with bootstrap alpha.6

lucasgladding commented 7 years ago

It looks like they just switched 'open' to 'show' on the dropdown parent. A quick fix would be adding this as custom CSS to your project.

.open {
  > .dropdown-menu {
    display: block;
  }
  > a {
    outline: 0;
  }
}

I'll try to put together a pull request for it. I would just add 'show' to the select component template, though I need to check to confirm that.

coyotte508 commented 7 years ago

Another temporary fix is:

  <script src="https://v4-alpha.getbootstrap.com/dist/js/bootstrap.min.js"></script>

They have the correct javascript already on their demo page.

optimistex commented 6 years ago

Work by supporting Bootstrap 4 was planned: https://github.com/optimistex/ng2-select-ex/issues/5