valor-software / ng2-select

Angular based replacement for select boxes
http://valor-software.github.io/ng2-select/
MIT License
675 stars 587 forks source link

Fixed multiple enter issue #838

Open dan12mol opened 7 years ago

dan12mol commented 7 years ago

Fixes #72 which was already previously fixed but the issues popped up again after introducing SelectItem

codecov[bot] commented 7 years ago

Codecov Report

Merging #838 into development will decrease coverage by 1.44%. The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #838      +/-   ##
===============================================
- Coverage        31.77%   30.33%   -1.45%     
===============================================
  Files               11       11              
  Lines              450      445       -5     
  Branches            71       72       +1     
===============================================
- Hits               143      135       -8     
- Misses             307      309       +2     
- Partials             0        1       +1
Impacted Files Coverage Δ
src/select/select.ts 18.78% <0%> (-1.4%) :arrow_down:
src/select/select-pipes.ts 31.57% <0%> (-3.43%) :arrow_down:
src/select/off-click.ts 70% <0%> (-2.73%) :arrow_down:
src/select/select.module.ts 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3afaf63...9e7cc82. Read the comment docs.

psilospore commented 7 years ago

@dan12mol would you be interested in creating a PR into our fork https://github.com/psilospore/ng-next-select I don't this repo is being maintained anymore.

dan12mol commented 7 years ago

@psilospore absolutely, will get on this asap and will submit a PR one of these days. Thanks for the info 👍