search

valor-software / ng2-select

Angular based replacement for select boxes
http://valor-software.github.io/ng2-select/
MIT License
675 stars 587 forks source link

clear active on items change #844

Open AdaAdamczak opened 7 years ago

AdaAdamczak commented 7 years ago

it doesn't make sense for active item(s) to stay as is on items change

codecov[bot] commented 7 years ago

Codecov Report

Merging #844 into development will decrease coverage by 1.5%. The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #844      +/-   ##
===============================================
- Coverage        31.77%   30.26%   -1.51%     
===============================================
  Files               11       11              
  Lines              450      446       -4     
  Branches            71       73       +2     
===============================================
- Hits               143      135       -8     
- Misses             307      310       +3     
- Partials             0        1       +1
Impacted Files Coverage Δ
src/select/select.ts 18.73% <0%> (-1.45%) :arrow_down:
src/select/select-pipes.ts 31.57% <0%> (-3.43%) :arrow_down:
src/select/off-click.ts 70% <0%> (-2.73%) :arrow_down:
src/select/select.module.ts 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3afaf63...502161f. Read the comment docs.

psilospore commented 7 years ago

@AdaAdamczak would you be interested in creating a PR into our fork https://github.com/psilospore/ng-next-select I don't this repo is being maintained anymore.