valor-software / ng2-select

Angular based replacement for select boxes
http://valor-software.github.io/ng2-select/
MIT License
676 stars 588 forks source link

Please add functionality to make it compatible with form-controls #941

Closed mayorquin closed 6 years ago

mayorquin commented 6 years ago

Add the "required" and the functionality to check is form or control is valid

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8aee01c). Click here to learn what that means. The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #941   +/-   ##
=========================================
  Coverage          ?   89.83%           
=========================================
  Files             ?       14           
  Lines             ?      413           
  Branches          ?       68           
=========================================
  Hits              ?      371           
  Misses            ?       19           
  Partials          ?       23
Impacted Files Coverage Δ
src/app/demo/select/multiple-demo.ts 100% <100%> (ø)
src/app/demo/select/children-demo.ts 100% <100%> (ø)
src/app/lib/public_api.ts 100% <100%> (ø)
src/polyfills.ts 100% <100%> (ø)
src/app/demo/select/rich-demo.ts 100% <100%> (ø)
src/test.ts 100% <100%> (ø)
src/app/demo/select-section.ts 100% <100%> (ø)
src/app/demo/sample-section.component.ts 100% <100%> (ø)
src/app/demo/select/no-autocomplete-demo.ts 100% <100%> (ø)
src/app/lib/ngx-select/ngx-select.module.ts 100% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aee01c...32ba202. Read the comment docs.