search

valor-software / ng2-select

Angular based replacement for select boxes
http://valor-software.github.io/ng2-select/
MIT License
675 stars 587 forks source link

RxJS6 code migration #971

Open prikryl opened 5 years ago

prikryl commented 5 years ago

removed rxjs-compat dependency. Fixed imports to rxjs/operators. Migrated code to RxJS6 style.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8aee01c). Click here to learn what that means. The diff coverage is 81.41%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #971   +/-   ##
========================================
  Coverage          ?   82.6%           
========================================
  Files             ?      13           
  Lines             ?     575           
  Branches          ?     137           
========================================
  Hits              ?     475           
  Misses            ?      21           
  Partials          ?      79
Impacted Files Coverage Δ
src/test.ts 100% <100%> (ø)
src/app/demo/sample-section.component.ts 45.45% <14.28%> (ø)
src/app/lib/ngx-select/ngx-templates.directive.ts 68.42% <45.45%> (ø)
src/app/lib/ngx-select/ngx-select.module.ts 54.54% <50%> (ø)
src/app/demo/select/children-demo.ts 63.63% <55.55%> (ø)
src/app/demo/select/rich-demo.ts 58.82% <56.25%> (ø)
src/app/app.component.ts 62.5% <60%> (ø)
src/app/demo/select/no-autocomplete-demo.ts 71.42% <62.5%> (ø)
src/app/demo/select/multiple-demo.ts 66.66% <63.63%> (ø)
src/app/demo/select-section.ts 69.23% <69.23%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aee01c...d15d6ce. Read the comment docs.

optimistex commented 5 years ago

Merged into the fork: https://github.com/optimistex/ngx-select-ex

gagandeepp commented 5 years ago

IS this still open?