search

valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.53k stars 1.69k forks source link

chore(build): add systemjs bundles #23

Closed ludohenin closed 8 years ago

ludohenin commented 9 years ago

Would be very nice to have a dist folder with a bundled file build with systemjs (register).

valorkin commented 9 years ago

@ludohenin unfortunately I am not really familiar with bundling with system.js but it works with system.js anyway https://github.com/pkozlowski-opensource/ng2-play/pull/34

ludohenin commented 9 years ago

I'll try to propose you something. Btw I also got it working here https://github.com/ludohenin/angular2-seed-ng2-bootstrap. The things is that it's not as straight forward as adding a script tag in the html document.

valorkin commented 9 years ago

In this question I agree with redux guys:

If you don’t yet use npm or a modern module bundler, and would rather prefer a single-file UMD build that makes Redux available as a global object, you can grab a pre-built version from cdnjs. We don’t recommend this approach for any serious application, as most of the libraries complementary to Redux are only available on npm.

https://www.npmjs.com/package/redux

but I was planning to add bundled version later, not prio, If you have an idea how I can do I will gladly apply it to all modules https://github.com/valor-software/ng2-plans :)

ludohenin commented 9 years ago

Yeah agree with you. interesting (long) discussion https://github.com/angular/angular/issues/4278 about this topic.

valorkin commented 9 years ago

I suppose soon we will see some common approach to building\bundling modules so we can use it

ludohenin commented 9 years ago

Making a quick custom build (with system at least) isn't that hard. I think it's fine like this. If I had to distribute bundles, I would do cjs only, one with full deps (ng2 + deps), and one with just the lib. Can be convenient for quick trial, prototype. The example integration with angular2-seed is basically the lib alone.

sirwolfgang commented 8 years ago

This would be very nice in at least some form of docs. The official ng2 starting tutorial uses systemjs.

valorkin commented 8 years ago

published new version with system.js bundles https://www.npmjs.com/package/ng2-bootstrap#quick-start