search

valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.53k stars 1.69k forks source link

Empty Popover being shown when no contents are present #4227

Closed coderundebug12 closed 6 years ago

coderundebug12 commented 6 years ago

<ng-template #popTemplate> <div ngIf="limitAmountinfo.errors == undefined">{{limitAmount}}

<div ngIf="limitAmountinfo.errors?.required">Mandatory Field
<div ngIf="limitAmountinfo.errors?.Decimal">Decimal Error <div ngIf="limitAmountinfo.errors?.maxlength">Number Length Error <div *ngIf="limitAmountinfo.errors?.MKB">Multiplier Error <label for="limiter" [popover]="popTemplate" placement="right" triggers="blur" [isOpen]="visibleControl.limitAmount" (click)="showPopver('limitAmount')"> <input id="limiter" class="limiter" autocomplete="off"
type="text" name="limitAmount" [popover]="limitAmount" placement="right" triggers="mouseenter:mouseleave" [(ngModel)]="limitAmount" [ngModelOptions]="{updateOn: 'blur'}" appDecimalValidator appMultiplierValidator appNumberLength appFormatNumber required

limitAmountinfo="ngModel">

valorkin commented 6 years ago

Pop over is not empty cuz value is set ( ngTemplate ref), popover can't see a context and should not. What I see here, that I should add isDisabled for popovers.

As for this issues, it works as expected