valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.53k stars 1.69k forks source link

feat(tabs): request to rewrite #4356

Open buchslava opened 6 years ago

buchslava commented 6 years ago

Tabs component: request to rewrite.

First of all, tabs solution should be implemented in accordance with modern Angular versions. For example like this: https://stackblitz.com/edit/angular-dynamic-tabs

Apart from that, I have following requirements for the component:

  1. Ability to use a different kind of components under dynamic tabs (at least, an example should be provided)

  2. Logo before heading -> ability to use space before heading (at least an example should be implemented): screenshot from 2018-05-17 11-30-54

  3. Ability to use space after the last tab should be available: for example, for add new tab button placing screenshot from 2018-05-17 11-31-06

  4. 'wrap mode' feature should be provided:

    • wrap=='true': tabs should be wrapped if not enough space to place them in one row
    • wrap=='false': tabs should be placed under separate row and arrow controls should be present if not enough space to place all of the tabs in one row screenshot from 2018-05-17 11-32-08
  5. tab title editing onfly:

    • double click on a title -> editing mode
    • enter - accept changes
    • esc - discard changes screenshot from 2018-05-17 11-32-23
  6. tabs swapping via Drag&Drop (optional)

  7. events for all of the tabs modification kinds should be implemented: add tab, remove tab, title changed...

tucq88 commented 6 years ago

This is awesome! +1000