search

valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.52k stars 1.69k forks source link

Feature request for modal via service: show backdrop for each nested modal #4779

Open exsoflowe opened 5 years ago

exsoflowe commented 5 years ago

Feature request:

If I use nested modals, modal service can show only one backdrop. See demo in documentation: https://valor-software.com/ngx-bootstrap/?gclid=EAIaIQobChMI2Nv51f2_3gIVRqQYCh1dOgJhEAAYASAAEgJrEPD_BwE#/modals#service-nested

There is condition for this behavior in _showBackdrop() method: https://github.com/valor-software/ngx-bootstrap/blob/development/src/modal/bs-modal.service.ts if (this.modalsCount === 1) {...}

But directive mode has difference: each nested modal has own backdrop. See demo in documentation: https://valor-software.com/ngx-bootstrap/?gclid=EAIaIQobChMI2Nv51f2_3gIVRqQYCh1dOgJhEAAYASAAEgJrEPD_BwE#/modals#directive-nested

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 3.1.1 and lower

Angular: 5, 6, 7

Bootstrap: any

Could you explain this difference in behavior? Thanks.

bhaskerchari commented 5 years ago

Any update on this issue? Its just hanging around for a while without any update or progress.

gittyhub15 commented 3 years ago

This feature would be a great addition and much needed.