search

valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.53k stars 1.69k forks source link

Missing exposed props that I was using before - maxMode, formatDay #5775

Open talamaska opened 4 years ago

talamaska commented 4 years ago

I'm using the directive bsDatepcker, I see minMode is exposed and the config is set to the component date picker, but the maxMode is missing. https://github.com/valor-software/ngx-bootstrap/blob/f6240fac0cbf2bfbe92be48eb61d3b35837517ba/src/datepicker/bs-datepicker.component.ts#L270

Also I see the formatDay is existing property, but I don't find a way to set it as well, please expose it in the bsConfig as well

https://github.com/valor-software/ngx-bootstrap/blob/fe7e4894a3e27968c82e4a4d9bb9b845b0b54dca/src/datepicker/datepicker.component.ts#L76

talamaska commented 4 years ago

If I make a pull request for the minMode, is there someone to merge it? I'm not sure I can make the formatDay exposed.