valor-software / ngx-bootstrap

Fast and reliable Bootstrap widgets in Angular (supports Ivy engine)
https://valor-software.com/ngx-bootstrap
MIT License
5.53k stars 1.69k forks source link

Node 18 error #6569

Open phyr0s opened 1 year ago

phyr0s commented 1 year ago

Description When compile using node 18. Actually looks like 9 arguments are passed

Expected Behavior *Compile without "skipLibCheck": true flag in the tsconfig.json

Actual Behavior `Error: node_modules/ngx-bootstrap/dropdown/bs-dropdown-container.component.d.ts:19:18 - error TS2707: Generic type 'ɵɵComponentDeclaration' requires between 7 and 8 type arguments.

19 static ɵcmp: i0.ɵɵComponentDeclaration<BsDropdownContainerComponent, "bs-dropdown-container", never, {}, {}, never, ["*"], false, never>;


Error: node_modules/ngx-bootstrap/dropdown/bs-dropdown-menu.directive.d.ts:7:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments.

7     static ɵdir: i0.ɵɵDirectiveDeclaration<BsDropdownMenuDirective, "[bsDropdownMenu],[dropdownMenu]", ["bs-dropdown-menu"], {}, {}, never, never, false, never>;

Error: node_modules/ngx-bootstrap/dropdown/bs-dropdown-toggle.directive.d.ts:20:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments.

20 static ɵdir: i0.ɵɵDirectiveDeclaration<BsDropdownToggleDirective, "[bsDropdownToggle],[dropdownToggle]", ["bs-dropdown-toggle"], {}, {}, never, never, false, never>;



Error: node_modules/ngx-bootstrap/dropdown/bs-dropdown.directive.d.ts:107:18 - error TS2707: Generic type 'ɵɵDirectiveDeclaration' requires between 6 and 8 type arguments.

107     static ɵdir: i0.ɵɵDirectiveDeclaration<BsDropdownDirective, "[bsDropdown], [dropdown]", ["bs-dropdown"], { "placement": "placement"; "triggers": "triggers"; "container": "container"; "dropup": "dropup"; "autoClose": "autoClose"; "isAnimated": "isAnimated"; "insideClick": "insideClick"; "isDisabled": "isDisabled"; "isOpen": "isOpen"; }, { "isOpenChange": "isOpenChange"; "onShown": "onShown"; "onHidden": "onHidden"; }, never, never, false, never>;`

Steps to Reproduce
Install lib with node 18
SvetlanaMuravlova commented 1 year ago

@phyr0s did you get this error with the last version?

robvaneck commented 1 year ago

I'm also getting this error with

    "@angular/common": "^14.2.5",
    "@angular/compiler": "^14.2.5",
    "@angular/compiler-cli": "^14.2.5",
    "@angular/core": "^14.2.5",
    "ngx-bootstrap": "^10.2.0",

For now, I did: tsconfig.json skipLibCheck: true

SvetlanaMuravlova commented 1 year ago

I've tested our last version with node v18.12.1 It works with angular 15

Screenshot 2023-04-04 at 12 48 30
SvetlanaMuravlova commented 1 year ago

@robvaneck this lib version is not compatibility with angular 14 https://valor-software.com/ngx-bootstrap/#/documentation#compatibility