valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
174 stars 86 forks source link

Biometrics on Android #2308

Closed kathaypacific closed 2 years ago

kathaypacific commented 2 years ago

Description

The initial experiment for biometrics was limited to only iOS users because the iOS keychain mechanism is more predictable and robust. This allowed us to develop and validate the feature faster.

The experiment yielded favourable results so we should enable it for all users. https://www.notion.so/valora-inc/Done-Biometric-option-9f3c0347b7c54a449b14ccd190b8314a

AC

Eng

Iris icon is here https://www.figma.com/file/j84MQn5xaOJ9RBjuIZgxPN/Onboarding-Experiments?node-id=1156%3A12577#179770055

Android 12 - look for bugs here Let's enable for the nightly build and test internally for a few weeks before releasing, to cover testing with more devices and uncover weird scenarios

kathaypacific commented 2 years ago

@nityarao we still need the iris image

kathaypacific commented 2 years ago

Update: it seems like biometrics on Android will (mostly) only work with fingerprint and not face. There are certain requirements that must be met for biometrics to be considered secure enough to access secret items in the Android key store and most android devices have weak face biometry. https://github.com/oblador/react-native-keychain/issues/301#issuecomment-1121971609

This means for most users,:

There are some devices like Pixel 4 which only has strong face biometry and no other biometry sensors. We need to test to see how this looks...