search

valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
171 stars 82 forks source link

Sending a transaction can cause the DEFAULT_FORNO_URL to be polled to frequently. #2668

Closed MuckT closed 2 months ago

MuckT commented 2 years ago

Current behavior

After sending a transaction the DEFAULT_FORNO_URL gets hit at least once per second indefinitely attempting to get the transaction receipt with requests containing the same body. Screen Shot 2022-07-01 at 4 19 59 PM

Desired behavior

The DEFAULT_FORNO_URL should not be polled indefinitely to get the transaction receipt. An exponential back-off and circuit breaker seems appropriate.

Steps to Reproduce

Prerequisites: Run the app in dev mode on either Mainnet or Alfajores. Have a tool such as flipper to observe network requests.

  1. Fund this account.
  2. Send a transaction.
  3. Observe network requests hitting the DEFAULT_FORNO_URL - forno.celo.org or alfajores-forno.celo-testnet.org

Versions

Valora 1.35.0

ellenwoconnor commented 1 year ago

Performance impact