search

valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
178 stars 87 forks source link

feat: update copy in buy and swap flows for UK compliance #6100

Closed kathaypacific closed 1 month ago

kathaypacific commented 1 month ago

Description

As the title

Test plan

Simulator Screenshot - iPhone 15 Pro - 2024-09-27 at 13 33 41 Simulator Screenshot - iPhone 15 Pro - 2024-09-27 at 13 33 15

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.74%. Comparing base (fcdb2af) to head (40e3528). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/swap/useFilterChips.ts 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/valora-inc/wallet/pull/6100/graphs/tree.svg?width=650&height=150&src=pr&token=ZQBexNu9cz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc)](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ```diff @@ Coverage Diff @@ ## main #6100 +/- ## ========================================== + Coverage 88.73% 88.74% +0.01% ========================================== Files 727 727 Lines 30763 30784 +21 Branches 5614 5316 -298 ========================================== + Hits 27298 27320 +22 - Misses 3267 3420 +153 + Partials 198 44 -154 ``` | [Files with missing lines](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) | Coverage Δ | | |---|---|---| | [.../fiatExchanges/FiatExchangeCurrencyBottomSheet.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2FfiatExchanges%2FFiatExchangeCurrencyBottomSheet.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL2ZpYXRFeGNoYW5nZXMvRmlhdEV4Y2hhbmdlQ3VycmVuY3lCb3R0b21TaGVldC50c3g=) | `93.65% <100.00%> (+0.31%)` | :arrow_up: | | [src/fiatExchanges/PaymentMethodSection.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2FfiatExchanges%2FPaymentMethodSection.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL2ZpYXRFeGNoYW5nZXMvUGF5bWVudE1ldGhvZFNlY3Rpb24udHN4) | `96.29% <100.00%> (+0.14%)` | :arrow_up: | | [src/fiatExchanges/SelectProvider.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2FfiatExchanges%2FSelectProvider.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL2ZpYXRFeGNoYW5nZXMvU2VsZWN0UHJvdmlkZXIudHN4) | `92.12% <100.00%> (+1.22%)` | :arrow_up: | | [src/statsig/types.ts](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2Fstatsig%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL3N0YXRzaWcvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | | | [src/swap/SwapScreen.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2Fswap%2FSwapScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL3N3YXAvU3dhcFNjcmVlbi50c3g=) | `93.64% <100.00%> (+0.04%)` | :arrow_up: | | [src/swap/useFilterChips.ts](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?src=pr&el=tree&filepath=src%2Fswap%2FuseFilterChips.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL3N3YXAvdXNlRmlsdGVyQ2hpcHMudHM=) | `96.77% <83.33%> (-3.23%)` | :arrow_down: | ... and [65 files with indirect coverage changes](https://app.codecov.io/gh/valora-inc/wallet/pull/6100/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Last update [fcdb2af...40e3528](https://app.codecov.io/gh/valora-inc/wallet/pull/6100?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc).