search

valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
178 stars 87 forks source link

fix(feed): use the right earn amount #6111

Closed satish-ravi closed 1 month ago

satish-ravi commented 1 month ago

Description

Use the deposit out and withdraw in amounts in the tx feed item for earn deposit and withdraw instead of the deposit in and withdraw out amounts (which are the LP token amounts)

Test plan

Before After

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.75%. Comparing base (9ae02ee) to head (7889be5). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/valora-inc/wallet/pull/6111/graphs/tree.svg?width=650&height=150&src=pr&token=ZQBexNu9cz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc)](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ```diff @@ Coverage Diff @@ ## main #6111 +/- ## ======================================= Coverage 88.74% 88.75% ======================================= Files 727 727 Lines 30786 30785 -1 Branches 5319 5319 ======================================= + Hits 27322 27324 +2 + Misses 3420 3417 -3 Partials 44 44 ``` | [Files with missing lines](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) | Coverage Δ | | |---|---|---| | [src/transactions/feed/EarnFeedItem.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?src=pr&el=tree&filepath=src%2Ftransactions%2Ffeed%2FEarnFeedItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL3RyYW5zYWN0aW9ucy9mZWVkL0Vhcm5GZWVkSXRlbS50c3g=) | `100.00% <100.00%> (ø)` | | | [test/values.ts](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?src=pr&el=tree&filepath=test%2Fvalues.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-dGVzdC92YWx1ZXMudHM=) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/valora-inc/wallet/pull/6111/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Last update [9ae02ee...7889be5](https://app.codecov.io/gh/valora-inc/wallet/pull/6111?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc).