search

valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
178 stars 87 forks source link

chore(earn): Beefy terms and conditions changes #6127

Closed finnian0826 closed 1 month ago

finnian0826 commented 1 month ago

Description

Allow for showing provider docs and valora T&Cs if provider T&Cs don't exist

Test plan

https://github.com/user-attachments/assets/a3ea05b2-a4f7-49c7-b753-745f62290c27

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.75%. Comparing base (c0a9178) to head (2f53107).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/valora-inc/wallet/pull/6127/graphs/tree.svg?width=650&height=150&src=pr&token=ZQBexNu9cz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc)](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ```diff @@ Coverage Diff @@ ## main #6127 +/- ## ======================================= Coverage 88.75% 88.75% ======================================= Files 727 727 Lines 30794 30804 +10 Branches 5627 5626 -1 ======================================= + Hits 27330 27339 +9 - Misses 3265 3266 +1 Partials 199 199 ``` | [Files with missing lines](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) | Coverage Δ | | |---|---|---| | [src/analytics/Properties.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?src=pr&el=tree&filepath=src%2Fanalytics%2FProperties.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL2FuYWx5dGljcy9Qcm9wZXJ0aWVzLnRzeA==) | `100.00% <ø> (ø)` | | | [src/earn/EarnDepositBottomSheet.tsx](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?src=pr&el=tree&filepath=src%2Fearn%2FEarnDepositBottomSheet.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc#diff-c3JjL2Vhcm4vRWFybkRlcG9zaXRCb3R0b21TaGVldC50c3g=) | `98.76% <100.00%> (+1.58%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/valora-inc/wallet/pull/6127/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Last update [c0a9178...2f53107](https://app.codecov.io/gh/valora-inc/wallet/pull/6127?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valora-inc).