valora-inc / wallet

The official repository for the Valora mobile cryptocurrency wallet.
https://valora.xyz
Apache License 2.0
172 stars 85 forks source link

Need loading state for contact importing on Send screen to avoid “No Contacts Found” being shown while import is in progress #629

Closed Lss-Ankit closed 1 year ago

Lss-Ankit commented 4 years ago

Frequency: 100% Repro App version: Celo integration build v1.8.2 (36) Repro on device:iPhone XS max (13.1), iphone 6+ (12.4.5) Tested Account: 503 447 5958 / Backup Key

Pre-condition: Application is launch after cold launch the app.

Repro Steps: 1) Launch app and login with tested account 2) Tap on Hamburger menu. 3) Tap on Invite option. 4) Observe.

Current Behavior: “No contact found” screen is shown for while Expected Behavior: “Fecting contact” should be display if contact are syncing in device

Design: Figma

Screen Shot 2020-06-26 at 11 23 52 AM

Attachment: ContactIssue .mp4 (Bug observed at 25 sec)

tarikbellamine commented 4 years ago

Fixed by @jmrossy

Lss-Ankit commented 4 years ago

Hi @tarikbellamine i have verified issue on latest test flight celo integration wallet build v1.8.2 (40) and found that issue is still reproduced.

Verified On: Iphone 6+ (12.4.5)

Please find the attachment for the same: Attachment: ContactIssue.mp4

tarikbellamine commented 4 years ago

The invite option will be removed in the next build. Can you reproduce this issue through Send or Request? If not, please close it.

Lss-Ankit commented 4 years ago

HI @tarikbellamine thanks for the updates!. I have verified the issue agian on send and request screen and found that issue is still reproduced.

Attachment: ContactSend&RequestIssue.mp4

jmrossy commented 4 years ago

@tarikbellamine @coreycelo Looks like we need a loading state for the Send screen while the app is still importing contacts

coreycelo commented 4 years ago

Updated the issue with a design to display a spinner.

ValoraQA commented 3 years ago

Hi @tarikbellamine We have verified this issue on latest android internal build V1.15.2 & Testflight build V1.15.2 (65) and observed issue is still repro. “No Contact” text is shown for while on “Contact Screen” when user open contact screen after cold the launch the app. Verified On: Iphone 6+ (12.4.5), Vivo V11 pro (10)