Zellic audit #2 feedback

[neodaoist]

• Semantic
  • Audit 2 feedback 3.1 — Remove settlementSeed updating in _assignExercise() function
  • Audit 2 feedback 3.2 — We have an elegant solution in development (https://github.com/valorem-labs-inc/LibDDRV), but it will not be included as part of our v1 release
  • Audit 2 Telegram feedback — Support off-chain claim accounting via bucket-related events (necessitated modification of _assignExercise() function signature, to pass in optionId parameter)
  • Correct the mutability of feeBps from immutable to constant, suppressing const-name-snakecase solhint warning (https://github.com/valorem-labs-inc/valorem-core/pull/201/files#diff-033680dc4cc50d115cdec7fe97c8be2fcf62aacef3c4b50b7c9979c08ad0027fR102)
• Syntactic
  • Rename OptionSettlementEngine to ValoremOptionsClearinghouse
  • Bump copyright year
  • Clarify and fix typos on few comments
  • Add ASCII art and top-line NatSpec to IValoremOptionsClearinghouse interface
  • Update trust model document to reflect the up-to-date implementation
• Deployment scripts
  • Support deploying to deterministic addresses
• CI
  • Re-enable integration tests
  • Exclude non-Clearinghouse tests from coverage report

Note: you can press a to toggle check annotations on/off

[codecov-commenter]

Codecov Report

Merging #199 (b7d28e2) into master (f085ad0) will increase coverage by 7.97%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   91.22%   99.20%   +7.97%     
==========================================
  Files           2        1       -1     
  Lines         376      250     -126     
  Branches       57       41      -16     
==========================================
- Hits          343      248      -95     
+ Misses         27        0      -27     
+ Partials        6        2       -4     

Impacted Files	Coverage Δ
src/ValoremOptionsClearinghouse.sol	99.20% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[0xAlcibiades]

@neodaoist please review the comment I left in the impl file; feel free to resolve it if we've already had that discussion.

other than that, it seems like the description of the PR is slightly off; the seed update is not included in the delta for this PR

They should be.

[neodaoist]

@neodaoist please review the comment I left in the impl file; feel free to resolve it if we've already had that discussion.

other than that, it seems like the description of the PR is slightly off; the seed update is not included in the delta for this PR

https://github.com/valorem-labs-inc/valorem-core/pull/199/files#diff-033680dc4cc50d115cdec7fe97c8be2fcf62aacef3c4b50b7c9979c08ad0027fL813