Closed neodaoist closed 1 year ago
Merging #205 (deb0e45) into v1.1.0 (48537e5) will not change coverage. The diff coverage is
n/a
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## v1.1.0 #205 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 1 1
Lines 250 250
Branches 41 41
=======================================
Hits 248 248
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I'd say it belongs to this ticket more than anything: https://github.com/valorem-labs-inc/valorem-frontend/issues/157
Because we aren't adding any test coverage or logic branch coverage here. Let's keep the clearinghouse code as lean as possible.
@0xAlcibiades This seems more like it belongs in anvil scripting for the frontend than the core contracts repo.
fair point.
otherwise @neodaoist this looks good, successfully minting them https://goerli.arbiscan.io/tx/0xd06fa7594153320095992578753159e2a6f6198eeb8d17609324895a1a4eb8af
Really appreciate you doing this!