valorem-labs-inc / clear

Valorem Clear is a DeFi money lego, enabling writing covered calls and cash-secured puts, physically settled or cash settled, American, European, and Exotic options.
https://valorem.xyz/docs/clear-overview/
Other
89 stars 12 forks source link

:sparkles: Script mock tokens and option types #205

Closed neodaoist closed 1 year ago

neodaoist commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #205 (deb0e45) into v1.1.0 (48537e5) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           v1.1.0     #205   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files           1        1           
  Lines         250      250           
  Branches       41       41           
=======================================
  Hits          248      248           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

0xAlcibiades commented 1 year ago

I'd say it belongs to this ticket more than anything: https://github.com/valorem-labs-inc/valorem-frontend/issues/157

Because we aren't adding any test coverage or logic branch coverage here. Let's keep the clearinghouse code as lean as possible.

nickadamson commented 1 year ago

@0xAlcibiades This seems more like it belongs in anvil scripting for the frontend than the core contracts repo.

fair point.

otherwise @neodaoist this looks good, successfully minting them https://goerli.arbiscan.io/tx/0xd06fa7594153320095992578753159e2a6f6198eeb8d17609324895a1a4eb8af

Really appreciate you doing this!