search

valorem-labs-inc / clear

Valorem Clear is a DeFi money lego, enabling writing covered calls and cash-secured puts, physically settled or cash settled, American, European, and Exotic options.
https://valorem.xyz/docs/clear-overview/
Other
89 stars 12 forks source link

Dry run deterministic deploys #211

Closed neodaoist closed 1 year ago

neodaoist commented 1 year ago

Confirmed that deployed addresses are the same on Goerli, Arb Goerli, and Op Goerli.

linear[bot] commented 1 year ago
VAL-341 Dry run deterministic deploys

AC * Replace 2 salts with 1 salt * Dry run on Arb Goerli and Opt Goerli to make sure address is the same

codecov[bot] commented 1 year ago

Codecov Report

Merging #211 (de20714) into master (d3458f1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files           1        1           
  Lines         250      250           
  Branches       41       41           
=======================================
  Hits          248      248           
  Partials        2        2
megsdevs commented 1 year ago

where is the command or script you used to run the deterministic deploy to on Goerli, Arb Goerli, and Op Goerli?

Can we add this info to the README

neodaoist commented 1 year ago

where is the command or script you used to run the deterministic deploy to on Goerli, Arb Goerli, and Op Goerli?

Can we add this info to the README

https://github.com/valorem-labs-inc/clear/blob/de20714f904d379ad271894769befdc0db04cd95/script/Deploy.s.sol#L12