valorin / pwned-validator

Super simple Laravel Validator for checking password via the Pwned Passwords service of Have I Been Pwned
MIT License
383 stars 24 forks source link

Laravel 7 compatibility #10

Closed SeinopSys closed 4 years ago

SeinopSys commented 4 years ago

I'd like to ask for an update to this package for Laravel 7

mralston commented 4 years ago

The package works in Laravel 7, it just won't install using composer because the required version of illuminate/support needs updating in the package's composer.json file.

I've opened a pull request. https://github.com/valorin/pwned-validator/pull/11

In the meantime, you're welcome to pull it into composer from my fork. Modify composer.json like so:

{
    ...
    "require": {
        ...
        "valorin/pwned-validator": "master"
        ...
    },
    ...
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/mralston/pwned-validator"
        }
    ]
}

Then run composer update.

I'll leave my fork available until the package has been updated in packagist.

valorin commented 4 years ago

I was going to check on it this afternoon, but I see a PR is already waiting for me. Thanks @mralston! 😁 I'll go ahead and approve and tag that right now. So you should be able to pull it into composer shortly.

valorin commented 4 years ago

v1.3.2 should be live now 👍

mralston commented 4 years ago

Nice. My first contribution to the open source community. 😊

valorin commented 4 years ago

That is awesome! 😃