valory-xyz / open-aea

A framework for open autonomous economic agent (AEA) development - no package vendor is prioritised over other package vendors
https://open-aea.docs.autonolas.tech
Apache License 2.0
65 stars 16 forks source link

Include ledger specifier when writing keys in a JSON file #711

Closed angrybayblade closed 9 months ago

angrybayblade commented 9 months ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to agents-aea? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d12acd2) 90.25% compared to head (128e768) 90.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #711 +/- ## ========================================== + Coverage 90.25% 90.26% +0.01% ========================================== Files 371 371 Lines 29816 29817 +1 ========================================== + Hits 26910 26914 +4 + Misses 2906 2903 -3 ``` | [Flag](https://app.codecov.io/gh/valory-xyz/open-aea/pull/711/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/valory-xyz/open-aea/pull/711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | `90.26% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.