search

valory-xyz / open-autonomy

A framework for the creation of autonomous agent services.
https://docs.autonolas.network
Apache License 2.0
80 stars 27 forks source link

Termination improvements #1505

Open 0xArdi opened 1 year ago

0xArdi commented 1 year ago
  1. Remove safe owner list reversal. https://github.com/valory-xyz/open-autonomy/pull/1459#discussion_r1011719332
  2. A more sophisticated termination logic. https://github.com/valory-xyz/open-autonomy/pull/1459#discussion_r1011720299
  3. Add with_termination(). https://github.com/valory-xyz/open-autonomy/pull/1459#discussion_r1011724787 https://github.com/valory-xyz/agent-academy-1/pull/155#discussion_r1013713819
  4. Add use_termination flag that will allow the operator to turn on/off termination.
  5. TerminationParams might have unwanted side effects https://github.com/valory-xyz/agent-academy-1/pull/155#discussion_r1013330491
0xArdi commented 1 year ago

The following can be added as well: https://github.com/valory-xyz/open-autonomy/pull/1643/commits/872f568a5b1acde66b77ef6fe7551f62682e2d5f#r1045780711

What we could do is ensure that the cross_period_persisted_keys defined in the TerminationAbciApp get also merged into the cross_period_persisted_keys of the "normal" AbciApp being executed. This would require small modification to the AbciApp.add_termination().
This would help us make sure that the cross_period_persisted_keys of the TerminationAbciApp get persisted properly, as there is no need to make the assumption that the cross_period_persisted_keys of the TerminationAbciApp are necessary anywhere else.
0xArdi commented 1 year ago

background_round_tx_type doesnt need to be exposed: https://github.com/valory-xyz/open-autonomy/pull/1674/files#r1051202881