Closed Adamantios closed 8 months ago
LGTM. Just one question: almost every line in our logs is usually duplicated. Does this PR fix that?
This is not resolved here.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
56bd6ff
) 94.29% compared to head (b7c6de9
) 94.28%.
Files | Patch % | Lines |
---|---|---|
...lory/skills/abstract_round_abci/behaviour_utils.py | 95.12% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
Update the level of the logs to hide unnecessary debugging information from the services' devs and to highlight the severity of some messages. Also, slightly improve the messages.
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
n/a