valory-xyz / open-autonomy

A framework for the creation of autonomous agent services.
https://docs.autonolas.network
Apache License 2.0
81 stars 26 forks source link

Improve framework's logging #2159

Closed Adamantios closed 8 months ago

Adamantios commented 9 months ago

Proposed changes

Update the level of the logs to hide unnecessary debugging information from the services' devs and to highlight the severity of some messages. Also, slightly improve the messages.

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an x in the box that applies

Checklist

Put an x in the boxes that apply.

Further comments

n/a

Adamantios commented 9 months ago

LGTM. Just one question: almost every line in our logs is usually duplicated. Does this PR fix that?

This is not resolved here.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (56bd6ff) 94.29% compared to head (b7c6de9) 94.28%.

Files Patch % Lines
...lory/skills/abstract_round_abci/behaviour_utils.py 95.12% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2159 +/- ## ========================================== - Coverage 94.29% 94.28% -0.01% ========================================== Files 260 260 Lines 16027 16042 +15 ========================================== + Hits 15113 15126 +13 - Misses 914 916 +2 ``` | [Flag](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | `94.28% <97.14%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.