valory-xyz / open-autonomy

A framework for the creation of autonomous agent services.
https://docs.autonolas.network
Apache License 2.0
80 stars 26 forks source link

Only warn once per attempt to reset Tendermint #2160

Closed Adamantios closed 7 months ago

Adamantios commented 7 months ago

Proposed changes

Only warn once per attempt to reset Tendermint. This was filling the logs too quickly, and also there was not meaning in continuously logging this message.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an x in the box that applies

Checklist

Put an x in the boxes that apply.

Further comments

n/a

0xArdi commented 7 months ago

Ive seen often that a lot of logs are produced when trying to retrieve params from ACN after an agent has crashed. It would be good we handle that case as well.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (refactor/logging@ca2b9ac). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## refactor/logging #2160 +/- ## =================================================== Coverage ? 94.29% =================================================== Files ? 259 Lines ? 16033 Branches ? 0 =================================================== Hits ? 15118 Misses ? 915 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | `94.29% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.