Fix/2203 - Githubissues

valory-xyz / open-autonomy

A framework for the creation of autonomous agent services.

Apache License 2.0

79 stars 25 forks source link

Proposed changes

Refactored the check_unreferenced_events function to return correct error strings, instead of misclassifying them.

Fixes

https://github.com/valory-xyz/open-autonomy/issues/2203

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an x in the box that applies

[x] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[x] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have locally run services that could be impacted and they do not present failures derived from my changes
[ ] Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
[ ] Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.42%. Comparing base (3b0b1a2) to head (3d37d6d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2207 +/- ## ======================================= Coverage 94.41% 94.42% ======================================= Files 260 260 Lines 16065 16064 -1 ======================================= Hits 15168 15168 + Misses 897 896 -1 ``` | [Flag](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/valory-xyz/open-autonomy/pull/2207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz) | `94.42% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valory-xyz#carryforward-flags-in-the-pull-request-comment) to find out more.