Closed angrybayblade closed 4 months ago
LGTM. Have you tested that with a service?
Do some tests need to be added in case the dev mode breaks again?
Also please provide details on how to use the dev mode after the new changes and what to expect.
LGTM. Have you tested that with a service? Do some tests need to be added in case the dev mode breaks again? Also please provide details on how to use the dev mode after the new changes and what to expect.
- Yes
- The actual deployments cannot be testes in the CI at the moment so no
- I've updated the documentation, you can take a look here - https://github.com/valory-xyz/open-autonomy/blob/123e085959f44f07db895b3a7cc44893e6a8e47d/docs/advanced_reference/developer_tooling/dev_mode.md
Isn't the dev
flag deprecated?
LGTM. Have you tested that with a service? Do some tests need to be added in case the dev mode breaks again? Also please provide details on how to use the dev mode after the new changes and what to expect.
- Yes
- The actual deployments cannot be testes in the CI at the moment so no
- I've updated the documentation, you can take a look here - https://github.com/valory-xyz/open-autonomy/blob/123e085959f44f07db895b3a7cc44893e6a8e47d/docs/advanced_reference/developer_tooling/dev_mode.md
Isn't the
dev
flag deprecated?
Yes, but it's deprecated on the autonomy build-image
not on autonomy deploy build
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.