Relax deps - Githubissues

kongzii commented 4 months ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.) Put an x in the box that applies

[ x] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

[ x] I have read the CONTRIBUTING doc
[ x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes
[ ] Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
[ ] Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

Locally I'm getting this error while running make common-checks-2 but that shouldn't be related to my changes.

I tried to install grpcio directly from pip, I tried upgrading of pip, installing -dev version of python, but so far nothing, do you have experience in running this on Mac with M2 please?

Screenshot by Dropbox Capture

8ball030 commented 1 month ago

@kongzii Are you still working on relaxing the dependencies here?

If so would you mind adding semver to you list of deps to relax?

At it looks to be pinned at;

semver (>=2.9.1,<3.0.0)

If we could get this changed it would be great.

Not even sure why where using semver! :)

kongzii commented 1 month ago

@8ball030 Just waiting for review and hopefully merge+release. Last commit was just to fix the docker version that was mentioned in a review elsewhere.

Could you clarify what you mean? I don't see any semver listed in dependencies. Maybe it's a subdependency of something?