Support Dart 2, prepare to release 2.1.3

[kevmoo]

Closes https://github.com/valotas/mustache4dart/pull/70

[kevmoo]

@valotas – you keeping track of these?

[valotas]

Hi Kevin,

Yes I am keeping track of these. For the moment dart 2 is supported but not the browser transpilation as I am making use of the mirrors API.

I am experimenting with a source generation solution. If you feel like helping have a look at the dart2 branch.

Cheers, George

On Thu, Jul 26, 2018, 20:38 Kevin Moore notifications@github.com wrote:

@valotas https://github.com/valotas – you keeping track of these?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/valotas/mustache4dart/pull/78#issuecomment-408176206, or mute the thread https://github.com/notifications/unsubscribe-auth/AABn87oZXf9KtbvEB_O8XIbL8FAsDIbTks5uKf6BgaJpZM4Vg_ci .

[kevmoo]

@valotas – awesome. Can we land this to unblock us for Dart2?

[valotas]

Hi @kevmoo,

This is a breaking change. In your PR you remove all the tests against older VMs plus current browser support.

Did you try the latest version of the library with dart2 and it doesn't work? If so what is the problem you experience.

[kevmoo]

Mirrors is 100% removed from the browser – so there is no way this will work in Dart 2 browser.

I removed all of the old SDKs because support for them is of diminishing returns. Already, must users hit our package site, etc are on v2-dev builds. I was trying to save you build times on Travis – just not worth it!

[valotas]

Can you please create a PR against dart2 branch? I do not feel like releasing anything without browser support. For that I have to first find out a way to replace mirrors. A solution would be a new major milestone but at the moment I am on vacation with limited internet access.

[nshahan]

It would be nice to have a version that can at least be used (not in a web environment) and can version solve with the 2.0.0 SDK release. At least as a stopgap until the full release without mirrors support is completed.

[valotas]

As I said, I have at the moment limited internet access. I can address this issue sometime starting from next week. Never the less I can not just merge a PR with a failing build nor can I create a new minor version dropping support of the current stable version of dart (I do not even understand why are you asking something like that).

What I can do is create a new major. Yet again, I can not just drop support of browsers as people again (to my surprise) rely on that.

Best thing would be to have something working on all environments (dart2, dart1 and browser). Any kind of help to that direction is more than welcome.

[valotas]

I am closing this as it is not relevant any more. v3 should be running just fine on dart2. Will release a non dev version as soon as browser support is ready

[kevmoo]

ack