search

valpackett / httpotion

[Deprecated because ibrowse is not maintained] HTTP client for Elixir (use Tesla please)
https://hexdocs.pm/httpotion/readme.html
The Unlicense
725 stars 100 forks source link

Catch missing messages in transformer fn #111

Closed ewildgoose closed 7 years ago

ewildgoose commented 7 years ago

ibrowse generates a number of other async_* messages which aren't currently caught

transformer function needs to also catch:

timeout messages in particular need to be caught since they otherwise leave the calling process hanging.

I have no idea what you would use the "raw_req" option for in practice, but seems sensible to support it since it exists...

valpackett commented 7 years ago

Thanks!

ewildgoose commented 7 years ago

Thanks! Really fast!

Slight curiosity in that I needed to create an extra connection... Seems that once the connection times out, then you cannot re-use it... Not quite sure I understand that? Perhaps ibrowse won't re-open connections?

Cheers

Ed W

On 17/05/2017 22:56, Greg wrote:

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/myfreeweb/httpotion/pull/111#issuecomment-302243030, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA0Nq1OBN2rbkoumBgx8dNDyEjHg_p3ks5r620fgaJpZM4Nee-K.

valpackett commented 7 years ago

I don't know. I actually don't use Elixir a lot… or at all really except for maintaining this library :D So I haven't looked into connection reuse.