valpackett / httpotion

[Deprecated because ibrowse is not maintained] HTTP client for Elixir (use Tesla please)
https://hexdocs.pm/httpotion/readme.html
The Unlicense
725 stars 100 forks source link

Response headers are converted to atoms #99

Closed schnittchen closed 8 years ago

schnittchen commented 8 years ago

Here: https://github.com/myfreeweb/httpotion/blob/master/lib/httpotion.ex#L73

Response headers are out of control of the application author and should be treated like user input. Converting string user input to atoms will eventually crash the machine. See also https://erlangcentral.org/wiki/index.php/Atom_Table

valpackett commented 8 years ago

Thanks! Released 3.0.2 with the fix.

schnittchen commented 8 years ago

That was swift! Thank you :)