search

valpackett / pcre-heavy

A Haskell regular expressions library that doesn't suck | now on https://codeberg.org/valpackett/pcre-heavy
https://codeberg.org/valpackett/pcre-heavy
The Unlicense
51 stars 6 forks source link

Use more accurate `cabal-version: >= 1.10` #3

Closed hvr closed 9 years ago

hvr commented 9 years ago

The previous >= 1.18 constraint made no sense as this doesn't unlock any used new Cabal features, while breaking compilation for older GHCs:

snap

Resolving dependencies...
Failed to install pcre-heavy-0.2.3
Build log ( /tmp/extra53361987086/.cabal-sandbox/logs/pcre-heavy-0.2.3.log ):
xcabal: Error: some packages failed to install:
pcre-heavy-0.2.3 failed during the configure step. The exception was:
user error (The package 'pcre-heavy' requires Cabal library version -any &&
>=1.18 but no suitable version is installed.)
valpackett commented 9 years ago

I was going to add base >= 4.7.0.0 to break compilation on older GHCs even more... :D Okay, let's try base >= 4.3.0.0 for now

hvr commented 9 years ago

That'd be a pity, because the code in the Git repo seems to build with GHC 7.0.4 just fine (if it wasn't for that cabal-version thingie) :-)

PS: Why did you use cabal-version: >=1.18 in the first place?

valpackett commented 9 years ago

I always seem to think that I use all the latest features, when actually I don't...

Released 0.2.4 with your change and base >= 4.3.0.0.

How does this matrix thing work? Is the authentication required to start the build the same as Hackage?

hvr commented 9 years ago

The authentication is not yet shared with Hackage proper. The builder is still in development. I've just triggered a rebuild.

hvr commented 9 years ago

coincidentally, the build fails for GHC 7.2 through 7.6 for the same reason as in X11 which I fixed just earlier today, see there for a way to fix this: https://github.com/haskell-pkg-janitors/X11/pull/33

I can send you a PR if you want

valpackett commented 9 years ago

There was a Foreign.unsafePerformIO on 7.2, 7.4 and 7.6? o_0

Uploaded 0.2.5 with the fix.

valpackett commented 9 years ago

And it builds! Thank you :-)

hvr commented 9 years ago

@myfreeweb 0.2.5 is all green now :-)

btw, are you interested in a Travis-CI config which tests with all major GHC 7.x versions? C.f. https://travis-ci.org/haskell-pkg-janitors/X11/builds/76856808

If yes, I can send you a PR

valpackett commented 9 years ago

I switched Travis to use stack instead of cabal-install... I could set it up with stack-7.8.yml etc., but I don't really care about old compilers.