search

valpackett / soundfixer

A WebExtension that lets you fix sound problems in e.g. YouTube videos
https://addons.mozilla.org/firefox/addon/soundfixer/
The Unlicense
222 stars 35 forks source link

Extension icon barely visible with dark themes #21

Closed Gitoffthelawn closed 3 years ago

Gitoffthelawn commented 4 years ago

With dark themes, the extension icon is barely visible.

This is true in the toolbar, the overflow menu ("More tools...") and when a dark theme is applied to about:addons.

I know the first two locations can be rectified; I'm not sure about the last one.

valpackett commented 3 years ago

Hm, for a long long time there's been an inverted icon set in theme_icons for the browser_actions. Just tested, works for me:

Screen_2021-05-31-21:10:19

Not currently possible for about:addons, but this looks okay to me:

Screen_2021-05-31-21:11:25

cheatfreak47 commented 3 years ago

Your icon has looked like this for me forever pretty much. Something must not be right. firefox_2021-09-15_05-32-08

valpackett commented 3 years ago

What theme are you using? Is the extension updated to the latest version? Completely silly suggestion but have you tried uninstalling and reinstalling it?

cheatfreak47 commented 3 years ago

I'm using the stock FireFox dark theme, and it's like this on my laptop as well on a brand new install of FireFox.

cheatfreak47 commented 3 years ago

firefox_2021-09-15_14-52-19 firefox_2021-09-15_14-53-55 As I said, I think something that's supposed to be working here just isn't.

valpackett commented 3 years ago

Oh. Damn. This is really stupid. So the theme color thing has only been working on HiDPI displays because of the size even though it's all SVG. I'll report this on bugzilla, and add an entry with smaller size for now.

valpackett commented 3 years ago

Submitted 1.2.2 to Mozilla. Angry comment: here :)

cheatfreak47 commented 3 years ago

yay, thanks for fixing it :) it's such a small thing but it made my night

Gitoffthelawn commented 3 years ago

@unrelentingtech Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?

valpackett commented 3 years ago

Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?

It's correct, "can be unused" of course. Maybe I should've just said "IS unused".

Gitoffthelawn commented 3 years ago

Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?

It's correct, "can be unused" of course. Maybe I should've just said "IS unused".

Ah, thanks. Now I see what you are saying. Yes, "IS unused" or "WILL BE unused" is clearer. Maybe worth an edit... maybe not. ;)