search

valpackett / soundfixer

A WebExtension that lets you fix sound problems in e.g. YouTube videos
https://addons.mozilla.org/firefox/addon/soundfixer/
The Unlicense
222 stars 35 forks source link

Bug Fix: Mono checkbox always unchecked after opening popup #24

Closed Vulcalien closed 3 years ago

Vulcalien commented 3 years ago

Problem

If I check Mono in the popup window, close the popup and open it again, Mono is always unchecked.

Fix

In the code, you use mono.value = settings.mono || false

I also wrote mono.checked = settings.mono || false I kept the mono.value line, just to be sure nothing breaks

valpackett commented 3 years ago

Nice catch. Please remove the mono.value line and the comment though.

Vulcalien commented 3 years ago

Sure! I'll get that fixed later.

Vulcalien commented 3 years ago

Ok fixed it