search

valr / cbatticon

A lightweight and fast battery icon that sits in your system tray
GNU General Public License v2.0
169 stars 41 forks source link

Please add option to white icons #71

Open Josse4Cats opened 2 years ago

Josse4Cats commented 2 years ago

Hi team

Sorry I have try to make the icon white and i dont´t find any way for this ..

kbhors commented 1 year ago

Well it's now June 2023 and you received no reply. I don't think the dev checks the issues page.

I also need to make the icon white. With the popularity of dark themes it's crazy there's apparently no battery monitors we can use!

valr commented 1 year ago

Hi @Josse4Cats, @kbhors, I must admit I forgot to reply to this, indeed.

I'm not sure how the have the icons white. The tool only refers to existing icon sets installed on the machine. It doesn't apply any change on them, and the gtk_status_icon_xxx functions don't seem such option available.

Would you know any tool having such option so that I could look at the code how it's done? Thanks

valr commented 1 year ago

Could you try if the merged code https://github.com/valr/cbatticon/pull/55 makes any difference to this issue? Thanks

kbhors commented 1 year ago

Hi @Josse4Cats, @kbhors, I must admit I forgot to reply to this, indeed.

I'm not sure how the have the icons white. The tool only refers to existing icon sets installed on the machine. It doesn't apply any change on them, and the gtk_status_icon_xxx functions don't seem such option available.

Would you know any tool having such option so that I could look at the code how it's done? Thanks

Eventually I gave up and simply changed the icon set. Which is a shame, because I don't see why icon sets should have anything to do with systray items. Icons are for files and folders. A systray item is fundamentally a button.

valr commented 1 year ago

@Josse4Cats, @kbhors, Would you have the possibility to test if the code that has been merged (PR #55) makes any difference to this issue?

The original explanation for the PR #55 is the following: "Currently cbatticon does not use the system configured Icons and Theme (.config/gtk-3.0/settings.ini). On my system this has the effect, that icons appear in the wrong color (dark icon on dark background)" So, it may be related.

mrgreen3 commented 1 year ago

Bit late to the party but I am having the same issue, Openbox running tint2 I have dark icon on a dark background. i3wm it works fine. As a workaround I have a coloured background in this case green. Really would like icon colour to be either white or add an option. If you need any output then please let me know.