Closed albacoretuna closed 4 years ago
This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://zeit.co/valstu/korona/ohfrzy50m ✅ Preview: https://korona-git-fork-albacoretuna-feature-translations.valstu.now.sh
Hey this is looking good! Will definitely review / merge this once it's finished đź‘Ť
Glad to hear @valstu
I translated the most important parts to English and Farsi. It still needs more work, but I think it's good enough to get reviewed.
As the Finnish language works as before, and now it has the translation for more other parts. If it gets merged, others can jump in and help with the translations as well.
By the way, I moved the details copy to the bottom of the page, as it was a mandatory scroll on any visit to get to the core of the page. Feel free to revert it if you don't like it.
Could we merge this instead of #13 ?
This project is very time sensitive, hopefully it won't be needed after few weeks 🙏
Data validity is already a bit questionable because the infection testing methods have changed. I added a warning about that to site just few minutes ago. But I'll review this now.
Yeah, heard about that.
I fix the merge conflict now.
Sure!
Could anyone help with translating this part to English:
HUOM! Testaustavan muutos vaikeuttaa tilannekuvan saamista
Lukujen luotettavuuteen vaikuttaa mm. pääkaupunkiseudun sairaanhoitopiirin Husin päätös rajoittaa testaamista vain tiettyihin tärkeisiin avainryhmiin. Entistä pienempi osa Husin alueella sairastuneista varmistetaan laboratoriossa.
I used my sparse finnish skills, it can be updated later with a better translation :D
I used my sparse finnish skills, it can be updated later with a better translation :D
Hah, your finnish skills seems really good đź‘Ť I'll merge this to master now and try to publish it today. Would it be huge task to translate the main text and warning text to Farsi later on?
Great!
Not really, I can add it whenever I find time.
Thanks for the nice project!
Are you open for adding English and other languages?
Here's a prototype I made, trying to do internationalization in a simple way. I first tried the recommended next package, but it was offering way more than is needed here and it involved changing so many fundamentals in the project that I didn't dare to change.
Let me know what you think, I understand if you'd like to skip it or do it in another way, I just wanted to do my share.