search

valstu / korona-info

Suomen koronavirus-tartuntatilanne
MIT License
67 stars 19 forks source link

Adding Russian translation #42

Open MrKalach opened 4 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/valstu/korona/pnmiqzjmc ✅ Preview: https://korona-git-fork-mrkalach-rutranslation.valstu.now.sh

MrKalach commented 4 years ago

Hey @valstu! Any chance to merge it?

valstu commented 4 years ago

Yeah, this looks good, we added few new translation keys for the bubble chart yesterday so those could be added. I just need to figure out a way to show all these translations since there are 3 other PRs waiting and the current language selecter needs to be restyled.

MrKalach commented 4 years ago

Maybe move all translations to separate files to utils/translations/{LANG}-translation.ts? Then dynamically include them (not sure, is it possible in TS)? Every include could itself add data to global phrases: { [key: string]: { [key: string]: string } }?

ps. I'm very far from TS and web dev. And maybe my ^^^ proposal is so stupid :)

MrKalach commented 4 years ago

@valstu I did update the PR. Conflicts fix.