search

valtech-sd / amqp-cacoon

AmqpCacoon is an abstraction around node-amqp-connection-manager that provides a simple interface with flow control, retries, reconnects, and more included out of the box.
MIT License
5 stars 4 forks source link

Improve amqp connection health testing #13

Closed aolivier closed 3 years ago

aolivier commented 4 years ago

See this group: https://groups.google.com/g/rabbitmq-users/c/Eegzba39PD4

EricWasTakenMJD commented 3 years ago

Going to resolve this by just not testing this in our library. In fact, in the latest PR I'm working on now, all "real host" tests are removed, meaning we're just mocking everything. Why? We just want to test our stuff. We will assume that the underlying libraries are handling all the things they say they handle. Reconnection testing is a feature of the underlying node amqp connection manager, so we'll just not test that here.

The PR where all this is changing is: https://github.com/valtech-sd/amqp-cacoon/pull/25